This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add license explanation to close button label #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1398 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
♿️ aspect: a11y
|
Size Change: +204 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
fix/license-explanation-popover-a11y
branch
from
2b18691 to
f5c967e
Compare
zackkrida
approved these changes
May 10, 2022
sarayourfriend
force-pushed
the
fix/license-explanation-popover-a11y
branch
from
f5c967e to
3175542
Compare
|
It's working in that you do have more context to the Close button, but you get the license description too, as part of the label: |
|
@obulat that is the expected behavior based on the issue. I think it's also nicer for SR users because they don't have to move through the popover (which is wordy and annoying to navigate through a screen reader, FWIW). |
obulat
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #987 by @zackkrida
Description
I tried to fix this as best I can, but it needs to be tested in VO and JAWS. I'm working on JAWS, but someone with a Mac will have to help with VO.
This adds the license explanation to the close button. That way when the SR opens the popover and the close button is focused, it reads the explanation and then also declares that the close button is focused (so that the user knows they can close the popover).
Testing Instructions
Checkout this branch and go to the search results page,
/search?q=birdsthen, navigating with a screen reader, open the filter sidebar and tab into it (note the experience here will improve with #1394). Focus the license explanation popover button. Open the popover and verify that the SR reads the license explanation and informs the user that they are on the close button for the popover and that you can close the popover successfully.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin